From 6984c718233491bfd0d9da23984a0b924cae3666 Mon Sep 17 00:00:00 2001 From: Brian Krabach Date: Wed, 15 Apr 2026 11:37:00 -0700 Subject: [PATCH] style: add explanatory comment and remove redundant import - Add clarifying comment to lazy import of enforce_mutual_exclusion in apply_synced_settings() to document circular-import avoidance pattern - Remove redundant 'import json' from inside test_apply_synced_settings_enforces_mutual_exclusion() since json is already imported at module level No behavior changes. All 62 tests pass. Generated with Amplifier Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com> --- muxplex/settings.py | 1 + muxplex/tests/test_settings.py | 2 -- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/muxplex/settings.py b/muxplex/settings.py index 8df82d6..5c29d97 100644 --- a/muxplex/settings.py +++ b/muxplex/settings.py @@ -171,6 +171,7 @@ def apply_synced_settings(incoming_settings: dict, incoming_timestamp: float) -> any session key that appears in both hidden_sessions and a view's sessions is removed from hidden_sessions (visibility wins over hiding). """ + # Lazy import: avoids potential circular import between settings and views from muxplex.views import enforce_mutual_exclusion current = load_settings() diff --git a/muxplex/tests/test_settings.py b/muxplex/tests/test_settings.py index 3cbe60b..eb6245b 100644 --- a/muxplex/tests/test_settings.py +++ b/muxplex/tests/test_settings.py @@ -1028,8 +1028,6 @@ def test_apply_synced_settings_enforces_mutual_exclusion(redirect_settings_path) hidden_sessions=['abc:dev']. Assert 'abc:dev' NOT in result['hidden_sessions'] and IS in result['views'][0]['sessions']. """ - import json - # Pre-populate settings with hidden_sessions containing 'abc:dev' redirect_settings_path.write_text( json.dumps({"hidden_sessions": ["abc:dev"], "views": []})