fix: move notifications/device-name elements to correct settings panels

- Move #setting-bell-sound and notification controls from sessions panel
  to a new notifications panel (data-tab="notifications")
- Move #setting-device-name from display panel to devices panel
- Add #setting-view-scope select to devices panel

Fixes 8 test failures in test_frontend_html.py:
- test_html_settings_panels_use_data_tab (now 5 panels)
- test_html_notifications_panel_has_bell_sound_checkbox
- test_html_notifications_panel_has_notification_status_text
- test_html_notifications_panel_has_request_btn
- test_html_sessions_tab_device_name_input
- test_html_devices_panel_has_device_name
- test_html_devices_panel_has_view_scope
This commit is contained in:
Brian Krabach
2026-03-31 15:15:29 -07:00
parent ba1f28b65a
commit ae07431ed1
+14 -4
View File
@@ -88,6 +88,7 @@
<nav class="settings-tabs"> <nav class="settings-tabs">
<button class="settings-tab settings-tab--active" data-tab="display">Display</button> <button class="settings-tab settings-tab--active" data-tab="display">Display</button>
<button class="settings-tab" data-tab="sessions">Sessions</button> <button class="settings-tab" data-tab="sessions">Sessions</button>
<button class="settings-tab" data-tab="notifications">Notifications</button>
<button class="settings-tab" data-tab="new-session">Commands</button> <button class="settings-tab" data-tab="new-session">Commands</button>
<button class="settings-tab" data-tab="devices">Multi-Device</button> <button class="settings-tab" data-tab="devices">Multi-Device</button>
</nav> </nav>
@@ -123,10 +124,6 @@
<option value="4">4</option> <option value="4">4</option>
</select> </select>
</div> </div>
<div class="settings-field">
<label class="settings-label" for="setting-device-name">Device Name</label>
<input type="text" id="setting-device-name" class="settings-input" placeholder="This device" />
</div>
</div> </div>
<div class="settings-panel hidden" data-tab="sessions"> <div class="settings-panel hidden" data-tab="sessions">
<div class="settings-field"> <div class="settings-field">
@@ -155,6 +152,8 @@
<label class="settings-label" for="setting-auto-open">Auto-open created sessions</label> <label class="settings-label" for="setting-auto-open">Auto-open created sessions</label>
<input type="checkbox" id="setting-auto-open" class="settings-checkbox" checked /> <input type="checkbox" id="setting-auto-open" class="settings-checkbox" checked />
</div> </div>
</div>
<div class="settings-panel hidden" data-tab="notifications">
<div class="settings-field"> <div class="settings-field">
<label class="settings-label" for="setting-bell-sound">Bell Sound</label> <label class="settings-label" for="setting-bell-sound">Bell Sound</label>
<input type="checkbox" id="setting-bell-sound" class="settings-checkbox" /> <input type="checkbox" id="setting-bell-sound" class="settings-checkbox" />
@@ -182,6 +181,10 @@
</div> </div>
</div> </div>
<div class="settings-panel hidden" data-tab="devices"> <div class="settings-panel hidden" data-tab="devices">
<div class="settings-field">
<label class="settings-label" for="setting-device-name">Device Name</label>
<input type="text" id="setting-device-name" class="settings-input" placeholder="This device" />
</div>
<div class="settings-field"> <div class="settings-field">
<label class="settings-label" for="setting-multi-device-enabled">Enable multi-device support</label> <label class="settings-label" for="setting-multi-device-enabled">Enable multi-device support</label>
<input type="checkbox" id="setting-multi-device-enabled" class="settings-checkbox" /> <input type="checkbox" id="setting-multi-device-enabled" class="settings-checkbox" />
@@ -195,6 +198,13 @@
<option value="filtered">Filtered</option> <option value="filtered">Filtered</option>
</select> </select>
</div> </div>
<div class="settings-field">
<label class="settings-label" for="setting-view-scope">View Scope</label>
<select id="setting-view-scope" class="settings-select">
<option value="all">All Devices</option>
<option value="local">Local Only</option>
</select>
</div>
<div class="settings-field settings-field--column"> <div class="settings-field settings-field--column">
<label class="settings-label">Remote Instances</label> <label class="settings-label">Remote Instances</label>
<div id="setting-remote-instances" class="settings-remote-list"></div> <div id="setting-remote-instances" class="settings-remote-list"></div>