ken/muxplex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: settings dialog always visible — display:flex overrode native <dialog> hidden state

Browse Source 
<dialog> is hidden by default via UA stylesheet (display:none). Our CSS
set display:flex unconditionally, overriding the UA rule and making the
dialog always visible. Fix: only apply display:flex when the dialog has
the [open] attribute (added by showModal()).
This commit is contained in:
Brian Krabach
2026-03-30 07:14:24 -07:00
parent 74a02cc05b
commit b38c87185a
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
muxplex/frontend/style.css
+7
View File
@@ -991,6 +991,13 @@ body {
padding: 0; padding: 0;
overflow: hidden; overflow: hidden;
margin: 0; margin: 0;
}
/* <dialog> is display:none by default (UA stylesheet). When opened via
showModal(), the browser adds the [open] attribute. We apply flex layout
only when open — otherwise our display:flex would override the UA
display:none and make the dialog always visible. */
.settings-dialog[open] {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
} }