ken/muxplex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(tests): clarify why logout tests bypass the shared client fixture

Browse Source 
The client fixture pre-injects a valid muxplex_session cookie to make
most tests pass auth middleware. Logout tests intentionally create their
own TestClient (without the cookie) to prove the endpoint works
correctly for unauthenticated and expired-session requests.

Co-authored-by: Amplifier <amplifier@sourcegraph.com>
This commit is contained in:
Brian Krabach
2026-03-28 22:36:09 -07:00
parent 2ca4420536
commit cf79d9fc9f
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
muxplex/tests/test_api.py
+5
View File
@@ -778,6 +778,11 @@ def test_post_login_pam_mode_wrong_creds(monkeypatch):
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------
# GET /auth/logout # GET /auth/logout
#
# Note: these tests intentionally bypass the shared `client` fixture.
# The `client` fixture pre-injects a valid muxplex_session cookie; these
# tests verify that logout works correctly even for an unauthenticated
# (or expired-session) request, so they create their own TestClient.
# --------------------------------------------------------------------------- # ---------------------------------------------------------------------------