ken/muxplex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test: clean up WebSocket auth test hygiene (unused fixture, deprecated cookies kwarg)

Browse Source
This commit is contained in:
Brian Krabach
2026-03-29 04:30:25 -07:00
parent 6c0bc80f21
commit d1d700e7fd
1 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
muxplex/tests/test_api.py
+6 -9
View File
@@ -838,7 +838,7 @@ def _wrap_with_client_host(wrapped_app, host: str):
return _middleware return _middleware
def test_ws_localhost_no_cookie_bypasses_auth(monkeypatch): def test_ws_localhost_no_cookie_bypasses_auth():
"""WebSocket from 127.0.0.1 is accepted even without a session cookie.""" """WebSocket from 127.0.0.1 is accepted even without a session cookie."""
from starlette.websockets import WebSocketDisconnect from starlette.websockets import WebSocketDisconnect
@@ -857,7 +857,7 @@ def test_ws_localhost_no_cookie_bypasses_auth(monkeypatch):
) )
def test_ws_valid_cookie_non_localhost_not_rejected_4001(monkeypatch): def test_ws_valid_cookie_non_localhost_not_rejected_4001():
"""WebSocket from non-localhost with a valid cookie is not rejected with 4001.""" """WebSocket from non-localhost with a valid cookie is not rejected with 4001."""
from starlette.websockets import WebSocketDisconnect from starlette.websockets import WebSocketDisconnect
from muxplex.auth import create_session_cookie from muxplex.auth import create_session_cookie
@@ -867,10 +867,9 @@ def test_ws_valid_cookie_non_localhost_not_rejected_4001(monkeypatch):
# TestClient default host is "testclient" — treated as non-localhost # TestClient default host is "testclient" — treated as non-localhost
with TestClient(app) as c: with TestClient(app) as c:
c.cookies["muxplex_session"] = cookie
try: try:
with c.websocket_connect( with c.websocket_connect("/terminal/ws") as _:
"/terminal/ws", cookies={"muxplex_session": cookie}
) as _:
pass # connection was accepted — auth passed pass # connection was accepted — auth passed
except WebSocketDisconnect as e: except WebSocketDisconnect as e:
# Auth passed; ttyd not running → proxy fails → close with code != 4001 # Auth passed; ttyd not running → proxy fails → close with code != 4001
@@ -896,10 +895,8 @@ def test_ws_invalid_cookie_non_localhost_rejected_4001():
from starlette.websockets import WebSocketDisconnect from starlette.websockets import WebSocketDisconnect
with TestClient(app) as c: with TestClient(app) as c:
c.cookies["muxplex_session"] = "tampered.invalid.cookie.value"
with pytest.raises(WebSocketDisconnect) as exc_info: with pytest.raises(WebSocketDisconnect) as exc_info:
with c.websocket_connect( with c.websocket_connect("/terminal/ws") as _:
"/terminal/ws",
cookies={"muxplex_session": "tampered.invalid.cookie.value"},
) as _:
pass pass
assert exc_info.value.code == 4001 assert exc_info.value.code == 4001