fix: resolve code review issues — schema mismatch, test fixes, pop-out render
- Fix a2ui-format.md schema to match renderer: rename 'options' → 'filters' in
filters block, replace 'active: boolean' with 'value: string' in filter options,
update form select options from string[] to {label, value}[] objects (Critical #1)
- Fix 3 failing tests in test_researcher_agent.sh to use @mention paths without .md
extension (Important #2)
- Complete pop-out feature in VisualBlock.handlePopOut() by posting render message
to popup window after 500ms initialization delay (Important #3)
- Update test_context_files.sh to match new a2ui-format.md schema (filters array
key check, value field check)
This commit is contained in:
@@ -60,12 +60,12 @@ check_contains "$A2UI" "a2ui fenced code block" '```a2ui'
|
||||
echo ""
|
||||
echo "=== Checking a2ui-format.md: block type 'filters' ==="
|
||||
check_contains "$A2UI" "filters type" '"type": "filters"'
|
||||
check_contains "$A2UI" "filters options array" '"options"'
|
||||
check_contains "$A2UI" "filters array key" '"filters"'
|
||||
check_contains "$A2UI" "Toyota option" '"Toyota"'
|
||||
check_contains "$A2UI" "Honda option" '"Honda"'
|
||||
check_contains "$A2UI" "Hyundai option" '"Hyundai"'
|
||||
check_contains "$A2UI" "Under \$5K option" '"Under $5K"'
|
||||
check_contains "$A2UI" "active field" '"active"'
|
||||
check_contains "$A2UI" "value field" '"value"'
|
||||
|
||||
echo ""
|
||||
echo "=== Checking a2ui-format.md: block type 'table' ==="
|
||||
|
||||
@@ -128,17 +128,17 @@ check_regex "user can take over via VNC" "VNC|vnc"
|
||||
echo ""
|
||||
echo "=== Checking body: A2UI section ==="
|
||||
check_contains "A2UI section header" "A2UI"
|
||||
check_contains "a2ui-format.md @mention" "bundle/context/a2ui-format.md"
|
||||
check_contains "a2ui-format @mention" "bundle/context/a2ui-format"
|
||||
|
||||
echo ""
|
||||
echo "=== Checking body: Artifacts section ==="
|
||||
check_contains "Artifacts section header" "Artifacts"
|
||||
check_contains "artifact-conventions.md @mention" "bundle/context/artifact-conventions.md"
|
||||
check_contains "artifact-conventions @mention" "bundle/context/artifact-conventions"
|
||||
|
||||
echo ""
|
||||
echo "=== Checking body: Inline Visuals section ==="
|
||||
check_contains "Inline Visuals section header" "Inline Visuals"
|
||||
check_contains "visual-artifacts.md @mention" "bundle/context/visual-artifacts.md"
|
||||
check_contains "visual-artifacts @mention" "bundle/context/visual-artifacts"
|
||||
check_regex "proactive visual generation mention" "proactive|visual.*generation|comparison.*table|chart"
|
||||
|
||||
echo ""
|
||||
|
||||
Reference in New Issue
Block a user