ken/research-workbench
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: resolve code review issues — schema mismatch, test fixes, pop-out render

Browse Source 
- Fix a2ui-format.md schema to match renderer: rename 'options' → 'filters' in
  filters block, replace 'active: boolean' with 'value: string' in filter options,
  update form select options from string[] to {label, value}[] objects (Critical #1)
- Fix 3 failing tests in test_researcher_agent.sh to use @mention paths without .md
  extension (Important #2)
- Complete pop-out feature in VisualBlock.handlePopOut() by posting render message
  to popup window after 500ms initialization delay (Important #3)
- Update test_context_files.sh to match new a2ui-format.md schema (filters array
  key check, value field check)
This commit is contained in:
Ken
2026-05-26 20:54:58 +00:00
parent 92df88975c
commit 2c3cfdbedc
4 changed files with 30 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_researcher_agent.sh
+3 -3
View File
@@ -128,17 +128,17 @@ check_regex "user can take over via VNC" "VNC|vnc"
echo ""
echo "=== Checking body: A2UI section ==="
check_contains "A2UI section header" "A2UI"
check_contains "a2ui-format.md @mention" "bundle/context/a2ui-format.md"
check_contains "a2ui-format @mention" "bundle/context/a2ui-format"
echo ""
echo "=== Checking body: Artifacts section ==="
check_contains "Artifacts section header" "Artifacts"
check_contains "artifact-conventions.md @mention" "bundle/context/artifact-conventions.md"
check_contains "artifact-conventions @mention" "bundle/context/artifact-conventions"
echo ""
echo "=== Checking body: Inline Visuals section ==="
check_contains "Inline Visuals section header" "Inline Visuals"
check_contains "visual-artifacts.md @mention" "bundle/context/visual-artifacts.md"
check_contains "visual-artifacts @mention" "bundle/context/visual-artifacts"
check_regex "proactive visual generation mention" "proactive|visual.*generation|comparison.*table|chart"
echo ""