ken/muxplex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

style: add explanatory comment and remove redundant import

Browse Source 
- Add clarifying comment to lazy import of enforce_mutual_exclusion
  in apply_synced_settings() to document circular-import avoidance pattern
- Remove redundant 'import json' from inside
  test_apply_synced_settings_enforces_mutual_exclusion()
  since json is already imported at module level

No behavior changes. All 62 tests pass.

Generated with Amplifier

Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This commit is contained in:
Brian Krabach
2026-04-15 11:37:00 -07:00
parent a3ff22dc02
commit 6984c71823
2 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
muxplex/settings.py
+1
View File
@@ -171,6 +171,7 @@ def apply_synced_settings(incoming_settings: dict, incoming_timestamp: float) ->
any session key that appears in both hidden_sessions and a view's sessions any session key that appears in both hidden_sessions and a view's sessions
is removed from hidden_sessions (visibility wins over hiding). is removed from hidden_sessions (visibility wins over hiding).
""" """
# Lazy import: avoids potential circular import between settings and views
from muxplex.views import enforce_mutual_exclusion from muxplex.views import enforce_mutual_exclusion
current = load_settings() current = load_settings()
muxplex/tests/test_settings.py
-2
View File
@@ -1028,8 +1028,6 @@ def test_apply_synced_settings_enforces_mutual_exclusion(redirect_settings_path)
hidden_sessions=['abc:dev']. hidden_sessions=['abc:dev'].
Assert 'abc:dev' NOT in result['hidden_sessions'] and IS in result['views'][0]['sessions']. Assert 'abc:dev' NOT in result['hidden_sessions'] and IS in result['views'][0]['sessions'].
""" """
import json
# Pre-populate settings with hidden_sessions containing 'abc:dev' # Pre-populate settings with hidden_sessions containing 'abc:dev'
redirect_settings_path.write_text( redirect_settings_path.write_text(
json.dumps({"hidden_sessions": ["abc:dev"], "views": []}) json.dumps({"hidden_sessions": ["abc:dev"], "views": []})